docs(qa): revise cli.doctor-health-report to revision 2 — the monorepo-anchored expected-fail is now a pass

[claude]

Fixes #10798

Revises cli.doctor-health-report in docs/qa/platform-checklist/areas/cli.json to revision 2. One item, one revision, one history entry — no other item in that file is touched (it is the hot shared file of the #10663 QA-run lane).

Why now

The item's last acceptance clause was an EXPECTED-FAIL recording a live product defect: findMissingTests / findDeprecatedUsages walked only <cwd>/packages/spec/src and printed ✓ Test coverage / ✓ Deprecations about a tree they never opened. #10679 landed the fix, so the clause had to invert or the item would instruct a runner to record a failure that no longer happens.

Written against a real run, not against the source

The clause a runner executes is an instruction, so the text was written from observed output. The shipped CLI was built from this base and driven in a real create-objectstack -t blank scaffold, and again from a monorepo checkout for the counterpart. Scaffold, verbatim:

  ℹ Test coverage         Skipped — no packages/spec/src in this directory (monorepo-only check)
  ℹ Deprecations          Skipped — no packages/spec/src in this directory (monorepo-only check)

and under -v, beneath each:

      → Looked for <cwd>/packages/spec/src and found nothing to walk. This check reads the
        monorepo's own spec sources, so outside that checkout it has no subject — and a ✓ here
        would be a claim about files doctor never opened.

Neither old ✓ appears, neither → Checking… step line appears, and the @objectstack/spec Not built row is absent — its probe is now gated on <cwd>/packages/spec/package.json. From the monorepo the scanned arm still runs: ✓ @objectstack/spec Built, the step lines, and the real ⚠ findings all print.

The measurement corrected more than the card predicted

The card expected one row in the first acceptance clause's enumeration to have become conditional (@objectstack/spec). The real report shows the enumeration was wrong about a second row too, and had been since revision 1: Installed packages was never unconditional — installedPackageLedgerChecks returns [] on a clean ledger, so the row appears only on a ledger failure or a skipped entry. That also contradicted the item's own clause 4, which describes it as a failure row. NODE_ENV and Tenancy posture are finding-only for the same reason.

So the clause now splits unconditional rows (Node.js, pnpm, TypeScript, Dependencies, Git, Environment files) from finding-only rows, each with the condition that produces it, rather than naming a single exception.

What changed in the item

• title — the tail declared the two ✓s an expected-fail; rewritten to the skip behaviour.
• acceptance[0] — row enumeration split unconditional vs finding-only; verify re-anchored.
• acceptance[7] — EXPECTED-FAIL inverted into an ordinary pass clause, with the printInfo-not-printWarning invariant stated (withholding a false ✓ must not manufacture a false ⚠).
• steps[0] and steps[6] — the enumeration, and the old "capture the two ✓ lines" step, rewritten to capture the skip rows and assert three absences.
• negative — the @objectstack/spec Not built entry flipped from an accepted note into a regression; two negatives added for the skip row's own wrong shapes (a ⚠ instead of a ℹ, and the row vanishing instead of printing).
• fixtures — the requires note now says both cwds must be run; the knownGaps configExists() anchor re-derived.
• source — doctor-unexamined-spec-tree.test.ts added to the unit pins.
• every line anchor in the item re-derived at this base. doctor.ts grew ~90 lines, so every number quoted at revision 1 had moved — including the ones in clauses this card did not otherwise touch.

Verification — union run at 0e833d5

gate	verdict line
pnpm check:doc-authoring	✓ doc authoring guard: 389 files clean — no bare metadata literals.
pnpm --filter @objectstack/lint run check:doc-formula-expressions	✓ check:doc-formula-expressions: 22 record-scoped formula example(s) across 420 files / 1447 TS blocks judged clean
pnpm check:nul-bytes	check-nul-bytes: OK (scanned 6400 text file(s) … no raw ASCII control bytes).
pnpm lint (repo-wide eslint . --no-inline-config, not narrowed)	exit 0
pnpm check:platform-checklist	1 problem(s) — pre-existing, see below

Gate families derived from the tree with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack against the actual change set, not from a recalled list.

check:platform-checklist reports exactly one problem, coverage.json · manifest: UNCLASSIFIED, and it is not from this change: reverting cli.json to bb006446 and re-running produced the identical single problem and the identical exit 1, and the problem names a file this PR does not touch. Filed separately as #11421. Nothing in the run names cli.json, so the revision bookkeeping this gate does enforce is well-formed.

Scope

• No packages/cli/** — the code fix already landed.
• No changeset: this publishes nothing. skip-changeset applied, matching the precedent for checklist-maintenance PRs (docs(qa): state the positive secret contract and de-flake the chart measurement in platform-core (#7573, #7569) #7636, docs(qa): correct five approvals checklist items against the #7517 run #7638, docs(qa-checklist): attachments-storage maintenance — totalSize step fix, ADR-0104 D3 receipt clause, and the scratch authz fixture landed permanently #7716, docs(qa): dedupe the private D11 defect and correct four stale sharing/security checklist texts #7717).
• Out of scope, filed rather than folded in: Checklist maintenance: cli.doctor-deprecation-scan is stale — its EXPECTED-FAIL describes a hint #10680 already rewrote, and #10679 moved every line anchor it quotes #11420 (the sibling item cli.doctor-deprecation-scan is stale on the same two counts — a hint that os doctor --scan-deprecations prescribes a codemod command that does not exist #10680 already rewrote, and a full anchor set moved by os doctor prints ✓ Test coverage / ✓ Deprecations about a tree it never examined (in any user app) #10679) and check:platform-checklist is red on main (coverage.json · manifest UNCLASSIFIED) and the gate is not CI-wired, so the red has no reporting channel #11421.

---

Generated by Claude Code