Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve select view update #271

Closed
wants to merge 6 commits into from
Closed

Improve select view update #271

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2ad0c02
Improve select view update
NekR Jan 7, 2015
c0a9ed7
Remove not needed checks
NekR Jan 15, 2015
2881d79
Remove simple way of select view handling
NekR Jan 15, 2015
52dc363
Temorary restore stickit custom value for all select options
NekR Jan 15, 2015
95d3488
Fix tests failures
NekR Jan 15, 2015
b469508
Fix tests failures
NekR Jan 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove simple way of select view handling
  • Loading branch information
@NekR
NekR committed Jan 15, 2015
commit 2881d7959c7f7febaeff414a8723f99e9aaa35e7
4 changes: 0 additions & 4 deletions backbone.stickit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,10 +513,6 @@
// If there are no `selectOptions` then we assume that the `<select>`
// is pre-rendered and that we need to generate the collection.
if (!selectConfig) {
// simple way
$el.val(val);
return;

// I do not know if it is possible that this method might be invoked
// each time with different params. I |selectConfig| might be present
// in future calls after one call with it,
Expand Down