Improve select view update

[NekR]

Remove unnecessary tree recreation when no selectConfig given.

Please review the code, there are additional comments inline. Thank you.

[NekR]

Ohh, build failed but I cannot find any info where it did. So still need a review..

[megawac]

If _.isArray(val) passes _.isObject(val) will pass as well. Check can just be _.isObject

[NekR]

This behavior of _.isObject is strange to me, but thanks for correction!

[NekR]

I mean I understand why, because it's JS and Array also is object, but I just thought what that helper is more advanced.

[NekR]

Hi there!

I just ran your tests on my PC and got these lines:

Took 943ms to run 374 tests. 328 passed, 46 failed.
Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file://test/vendor/runner.js. Domains, protocols and ports must match.

Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file://test/vendor/runner.js. Domains, protocols and ports must match.

Unsafe JavaScript attempt to access frame with URL about:blank from frame with URL file://test/vendor/runner.js. Domains, protocols and ports must match.

npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

How can I find details of those 46 failed tests?

Thank you.

[NekR]

Also please check code from this line: NekR@2ad0c02#diff-364c5eb07781db1e01c409c274426984R520
Does any one has thoughts about the way how that should be handled?

[NekR]

Ok, I temporarily restored full usage of "stickit-bind-val" but this does not fixed all fails. 6 of them are still remaining and I have no idea which they are.

[megawac]

@NekR http://rawgit.com/NekR/backbone.stickit/master/test/index.html

[NekR]

@megawac too late but thank you anyway! I just added manually logging in runner.js.

So now build is passed, please, review it again.

[pwolaq]

Hello,

Any update on this? It would be great to have documentFragment as it will really boost my application's performance.