Hang coconut issuance off the validator-api #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durch
changed the title
jstuczyn
reviewed
Jul 13, 2021
jstuczyn
requested changes
Jul 23, 2021
neacsu
force-pushed
the
validator-api-coconut
branch
3 times, most recently
from
b4f5f6a
to
2a0c3c5
Compare
jstuczyn
requested changes
Aug 6, 2021
There was a problem hiding this comment.
Considering we want to merge that puppy rather soon, I'd say the biggest things I'd really want changed before it are:
State::init()in coconut-interface- introduction of some error enum in the same file, it looks kinda messy with the String there
- creation of github issues/user stories for things I mentioned in other comments
| @@ -48,12 +50,29 @@ impl<'a> GatewayHandshake<'a> { | |||
| } | |||
| } | |||
|
|
|||
| // init: <- pub_key || g^x | |||
| let (remote_identity, remote_ephemeral_key) = check_processing_error( | |||
| // init: <- pub_key || g^x || credential | |||
There was a problem hiding this comment.
I wonder whether there might be some attack surface here if we're sending the credential in plain that is not bound to anyone. Perhaps it should be sent towards the end of the handshake so that it'd be encrypted with the derived shared key? I honestly don't know. Perhaps @aniampio might have an opinion
There was a problem hiding this comment.
As per the offline discussion, I'll do the credential send after the handshake, so that it's protected with the shared key.
... as config is no longer managed by rocket
neacsu
force-pushed
the
validator-api-coconut
branch
from
c63f208
to
4dd8c1a
Compare
... for the public attributes of the credential
Use the function from cli-demo-rs from https://github.com/nymtech/coconut to make the identity public key into a public attribute.
As we know beforehand the size of the keys, we can use fixed size array instead of vectors. This eliminates the need for a prefixed length in the serialized form of the InitMessage structure and enables a easy deserialization of the remote identity before the actual bincode deserialization that we do in the handshake process. Before this, the `extract_remote_identity_from_register_init` function attempted to deserialize into a public key the length-prefixed public key received from the client, thus failing sporadically with a `Cannot decompress Edwards point` error.
jstuczyn
reviewed
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Adds
coconutmod to validator APIAdds
tauri-clienttoclientsAdds
coconut-validator-interfacetocommonvalidator-apineeds a cocnut keypair to run, one can be generated via keygen-clisee README to run
I'll go about merging
develop, see if I can resolve the conflicts