Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gateway handshake's InitMessage deserialize directly into the needed structures #726

Open
neacsu opened this issue Aug 6, 2021 · 0 comments · May be fixed by 2g4y1/nym#17
Open

Make gateway handshake's InitMessage deserialize directly into the needed structures #726

neacsu opened this issue Aug 6, 2021 · 0 comments · May be fixed by 2g4y1/nym#17
Labels
enhancement New feature or request

Comments

@neacsu
Copy link
Contributor

neacsu commented Aug 6, 2021

Starting the conversation from #679 (comment) , we can improve InitMessage by having its elements deserialize directly into identity::PublicKey, encryption::PublicKey etc., without unwrap-ing from Vec<u8>s later.
@tommyv1987 tommyv1987 added the enhancement New feature or request label Nov 25, 2021
@snyk-bot snyk-bot linked a pull request Jan 6, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Core systems
Status: To analyse
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade @testing-library/react from 10.0.0 to 10.4.9 2g4y1/nym
2 participants
@neacsu @tommyv1987