Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(run): spawned process inherits stdout and is not detached #176

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(run): spawned process inherits stdout and is not detached #176

merged 1 commit into from
Jun 4, 2024

Conversation

stepancar
Copy link
Contributor

@stepancar stepancar commented Jun 4, 2024 •
edited by ayushmanchhabra
Loading

  • Pipe logs to stdout
  • Disable detached and allow process to kill nwjs

Fixes: #175

@ayushmanchhabra ayushmanchhabra changed the title fix(*): spawned process inherit stdout and not detached fix(run): spawned process inherits stdout and is not detached Jun 4, 2024
@ayushmanchhabra ayushmanchhabra merged commit df9fdc3 into nwjs:main Jun 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushmanchhabra ayushmanchhabra ayushmanchhabra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npx nw does not pipe stdout
2 participants
@stepancar @ayushmanchhabra