Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npx nw does not pipe stdout #175

Closed
stepancar opened this issue Jun 3, 2024 · 1 comment · Fixed by #176
Closed

npx nw does not pipe stdout #175

stepancar opened this issue Jun 3, 2024 · 1 comment · Fixed by #176

Comments

@stepancar
Copy link
Contributor

In this PR #150
spawned process initialized with stdio: 'ignore' which means, we can not get logs from chrome anymore

https://github.com/nwjs/npm-installer/pull/156/files#diff-ded7d82adc6eea35c2e80c2cf91ea002bd00db3073decc2812add012d5872efcR52

Is it an expected behaviour?
It seems like this change is not related to #150
@stepancar stepancar changed the title npx nw does not show stdout npx nw does not pipe stdout Jun 3, 2024
@ayushmanchhabra
Copy link
Collaborator

Can't remember why I did stdio ignore. Open to PR which pipes to stdout. I think all we have to do is change ignore to stdout?

@stepancar stepancar mentioned this issue Jun 4, 2024
Merged
ayushmanchhabra pushed a commit that referenced this issue Jun 4, 2024
@stepancar
fix(run): spawned process inherits stdout and is not detached (#176)
df9fdc3 
* Pipe logs to stdout
* Disable detached and allow process to kill nwjs

Fixes: #175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(run): spawned process inherits stdout and is not detached stepancar/npm-installer
2 participants
@stepancar @ayushmanchhabra