Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] add tests for "make 'nvm use' display '.nvmrc' version" #1258

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[Tests] add tests for "make 'nvm use' display '.nvmrc' version" #1258

wants to merge 2 commits into from
+38 −0

Commits on Aug 3, 2016

  1. [Fix] make nvm use display .nvmrc's version in output messages 

    Set $PROVIDED_VERSION equals to $NVM_RC_VERSION only if a .nvmrc file is
present and the user didn't provided a version to use (.ie typed `nvm
use`).

- Behavior before this fix :

nvm use
Found '.nvmrc' with version <v0.10.28>
N/A: version "N/A" is not yet installed.

You need to run "nvm install N/A" to install it before using it.

- Behavior after this fix :

nvm use
Found '.nvmrc' with version <v0.10.28>
N/A: version "v0.10.28" is not yet installed.

You need to run "nvm install v0.10.28" to install it before using it.
    @ljharb
    Olivier Martin DTSI/DSI authored and ljharb committed Aug 3, 2016
    Configuration menu
    Copy the full SHA
    c0e6d8f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2016

  1. [Tests] add tests for "make 'nvm use' display '.nvmrc' version" 

    See nvm-sh#1187.
    @jumbosushi @ljharb
    jumbosushi authored and ljharb committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    27dea68 View commit details
    Browse the repository at this point in the history