[Tests] add tests for "make 'nvm use' display '.nvmrc' version" #1258
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set $PROVIDED_VERSION equals to $NVM_RC_VERSION only if a .nvmrc file is present and the user didn't provided a version to use (.ie typed `nvm use`). - Behavior before this fix : nvm use Found '.nvmrc' with version <v0.10.28> N/A: version "N/A" is not yet installed. You need to run "nvm install N/A" to install it before using it. - Behavior after this fix : nvm use Found '.nvmrc' with version <v0.10.28> N/A: version "v0.10.28" is not yet installed. You need to run "nvm install v0.10.28" to install it before using it.
jumbosushi
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
from
15099cd
to
662735c
Compare
jumbosushi
changed the title
jumbosushi
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
from
662735c
to
8a08df3
Compare
ljharb
requested changes
Oct 11, 2016
| @@ -0,0 +1,18 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
this filename seems to start with a leading space - can you remove it?
There was a problem hiding this comment.
Also, can you add set -e - either here, or after the line that sources nvm.sh, if the tests fail when it's here?
There was a problem hiding this comment.
Fixed it!
EDIT: Also fix to chmod a+x
jumbosushi
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
2 times, most recently
from
ed14e79
to
3865e3f
Compare
|
Hm looks like my tests are failing. I will look into this |
ljharb
added
feature requests
jumbosushi
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
2 times, most recently
from
61db95d
to
93a587c
Compare
jumbosushi
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
from
93a587c
to
18a7190
Compare
|
@jumbosushi have you had a chance to look into this? |
|
Is this issue still needs to be opened ? My original one was resolved with new releases of nvm that might be the case for this one as well no ? |
ljharb
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
from
18a7190
to
0235dc8
Compare
|
The tests are still useful, even if the implementation change isn't. |
ljharb
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
2 times, most recently
from
ee9716e
to
2f7b7d2
Compare
ljharb
changed the title
ljharb
force-pushed
the
1187-display-nvrmrc-version-in-nvm-use
branch
from
2f7b7d2
to
27dea68
Compare
|
Tests failed; i restored the fix from #1187 to see if that makes them pass. |
|
@jumbosushi unfortunately the test fails with or without the fix. |
ljharb
force-pushed
the
master
branch
2 times, most recently
from
c6cfc3a
to
c20db2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of tests was asked by @ljharb for the pull request #1187 started by @anchnk, which was to display the versions of .nvmrc when "nvm use" is called.
This PR is a continuation of #1187 to add tests.
Let me know if anything needs to be changed!
EDIT: Added .nvmrc setup and cleanup in setup_dir and teardown_dir
EDIT2: Better error message