Skip to content

Show committer, upstream and date in branch finder #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Show committer, upstream and date in branch finder #695

merged 2 commits into from
Mar 29, 2021

Conversation

kyoh86
Copy link
Contributor

@kyoh86 kyoh86 commented Mar 28, 2021

Show short informations for all branches.

telescope-git

for: #569

@kkharji
Copy link
Member

kkharji commented Mar 29, 2021

That looks really nice, I'll test it out in few hours

@kkharji
Copy link
Member

kkharji commented Mar 29, 2021

LGTM,

@kkharji kkharji merged commit 2e03f67 into nvim-telescope:master Mar 29, 2021
end
local entry = vim.fn.json_decode(v)
if entry.head then
goto continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not use goto? It breaks lua 5.1 and some people have to build neovim with 5.1
Example: #518

@Conni2461
Copy link
Member

Conni2461 commented Mar 29, 2021

Also i think its a regression that the current branch is no longer indicated, don't you think so as well @ThePrimeagen, you requested that it is indicated in the first place. Now its no longer present at all.

Also with the date information we can also think of initial sorting based on the date.

I like everything else :) thanks

kkharji added a commit that referenced this pull request Mar 29, 2021
@elianiva elianiva mentioned this pull request Mar 29, 2021
@kyoh86 kyoh86 deleted the rich-branches branch March 29, 2021 22:46
@kyoh86 kyoh86 mentioned this pull request Mar 29, 2021
Conni2461 pushed a commit that referenced this pull request Apr 7, 2021
williamboman added a commit to williamboman/telescope.nvim that referenced this pull request Apr 14, 2021
* upstream/master:
  picker(live_grep): add option to grep only over open files (nvim-telescope#666)
  git(action): create and checkout branch (nvim-telescope#755)
  readme: fix broken links and spelling errors (nvim-telescope#753)
  added a new DynamicFinder (which can be used with rust_analyzer) (nvim-telescope#705)
  feat: add icons to git_status finder (nvim-telescope#401)
  fix: update to newer code (nvim-telescope#744)
  pickers(buffers): added only_cwd opt (nvim-telescope#739)
  feat: asyncify pickers - except for live_grep (nvim-telescope#709)
  fix: Use standardized names for current buffer fuzzy find (nvim-telescope#737)
  fix(git_branches): use the quoted fields instead of json-formatting and fix regressions with nvim-telescope#695 (nvim-telescope#704)
  feat: buf highlights for current buffer fuzzy find (nvim-telescope#732)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants