Skip to content

chore: fix lint error #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: fix lint error #676

wants to merge 2 commits into from

Conversation

elianiva
Copy link
Member

I did a mistake by not scrolling up the test log, so I missed one of the reason why the test was failing (long lines) and thought it was caused by trailing whitespace which is unrelated to the previous PR.

elianiva and others added 2 commits March 21, 2021 12:49
Co-authored-by: Jesse Leite <jesseleite@gmail.com>
@elianiva
Copy link
Member Author

and the doc gets removed for some reason :))
no idea about that

@Conni2461
Copy link
Member

docgen weirdness will be over soon. Promise. Just different ABI version. I explained it here: #664 (comment). Tj is aware of it (i told him) and i also saw this: https://twitter.com/TeejDeVries/status/1372881108979871749?s=20

@elianiva
Copy link
Member Author

elianiva commented Mar 29, 2021

moved the fix to #681, and #695 fixed it as well 😆

@elianiva elianiva closed this Mar 29, 2021
@elianiva elianiva deleted the nit/fix_lint branch March 29, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants