Skip to content

fix(renderer): remove closed windows from floating_windows #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2023
Merged

fix(renderer): remove closed windows from floating_windows #760

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eed49ef
fix bug
nhat-vo Feb 19, 2023
f9f8490
fix table.remove() bug
nhat-vo Feb 20, 2023
deae037
Merge branch 'main' into 759-floating-window-resize-bug
nhat-vo Feb 20, 2023
aeb0698
fix merge error
nhat-vo Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lua/neo-tree/ui/renderer.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,19 @@ local log = require("neo-tree.log")
local M = { resize_timer_interval = 50 }
local ESC_KEY = vim.api.nvim_replace_termcodes("<ESC>", true, false, true)
local default_popup_size = { width = 60, height = "80%" }
local floating_windows = {}
local draw, create_window, create_tree, render_tree

local floating_windows = {}
local update_floating_windows = function()
local valid_windows = {}
for _, win in ipairs(floating_windows) do
if M.is_window_valid(win.winid) then
table.insert(valid_windows, win)
end
end
floating_windows = valid_windows
end

-- clean up neotree buffers created by :mksession
local cleaned_up = false
local clean_neotree_buffers = function()
Expand Down Expand Up @@ -926,6 +936,7 @@ create_window = function(state)
end

M.update_floating_window_layouts = function()
update_floating_windows()
for _, win in ipairs(floating_windows) do
local opt = {
relative = "win",
Expand Down