fix(renderer): remove closed windows from floating_windows #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cseickel
reviewed
Feb 19, 2023
lua/neo-tree/ui/renderer.lua
Outdated
Comment on lines
928
to
930
| if M.is_window_valid(win.winid) == false then | ||
| table.remove(floating_windows, i) | ||
| else |
Contributor
There was a problem hiding this comment.
Removing values from the middle of a table you are iterating on is a bad idea and could produce bugs. In practice we don't usually have more than one window in this collection so you may not have noticed any bugs in testing, but one day this could come back to bite somebody.
It's also generally a good idea to use truthy assertions rather than negative ones where possible, because it is a little easier to read them.
I would suggest:
Suggested change
| if M.is_window_valid(win.winid) == false then | |
| table.remove(floating_windows, i) | |
| else | |
| valid_windows = {} | |
| if M.is_window_valid(win.winid) then | |
| table.insert(valid_windows, win) |
and then at the end of the loop you can assign:
floating_windows = valid_windowsto get rid of any invalid windows you may have found along the way.
Collaborator
Author
There was a problem hiding this comment.
Yes, thank you for the comment. I forgot the fact that table.remove() could cause bugs in a loop.
cseickel
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #759 by cleaning up invalid windows from
floating_windows, which is called onevents.VIM_RESIZED