Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Building with sccache instead of ccache #110

Closed
mdemoret-nv opened this issue May 17, 2022 · 0 comments · Fixed by #107
Closed

Allow Building with sccache instead of ccache #110

mdemoret-nv opened this issue May 17, 2022 · 0 comments · Fixed by #107
Assignees

Comments

@mdemoret-nv
Copy link
Contributor

In the PR to add a CI system, it was discovered that ccache doesnt work well between build stages. Instead, Morpheus should have the option to build using sccache.

Original comment from the PR review is below:

I think there might be a better way to configure using sccache. The script cmake/setup_cache.cmake does some templating to ensure ccache can figure out the compiler type during a conda-build run (look at the comments in that file for more info).

We could also just set the variable CCACHE_PROGRAM_PATH to sccache if they are drop in replacements for eachother.

Either way, we should make a new issue to explore this.

Originally posted by @mdemoret-nv in #80 (comment)

@mdemoret-nv mdemoret-nv mentioned this issue May 17, 2022
9 tasks
@dagardner-nv dagardner-nv self-assigned this May 23, 2022
This was referenced May 23, 2022
@ghost ghost closed this as completed in #107 Jun 8, 2022
ghost pushed a commit that referenced this issue Jun 8, 2022
+ Performs a non-inplace morpheus build.
+ Adds $ORIGIN to rpath of build binaries, fixing issue where libmorpheus.so was unable to find libmorpheus-utils.so (fixes #111 )
+ ~~Removes the need for a gpu for the build stage~~ Blocked by Neo/nvml issue #186
+ Common operations moved to common.sh
+ Fixes ci scripts so that they work locally (fixes #114 )
+ Improve the way sccache is configured (fixes #110 )

This pull req incorporates changes from #62

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Devin Robison (https://github.com/drobison00)
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #107
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants