Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins improvememts #107

Merged
310 commits merged into from
Jun 8, 2022
Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented May 13, 2022

This pull req incorporates changes from #62

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small changes and questions

ci/scripts/get_merge_target.py Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
ci/scripts/gitutils.py Outdated Show resolved Hide resolved
ci/scripts/jenkins/build.sh Show resolved Hide resolved
ci/scripts/jenkins/test.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We'll reevaluate the conda package zip later

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, one more change

ci/scripts/common.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit fc243ce into nv-morpheus:branch-22.06 Jun 8, 2022
@dagardner-nv dagardner-nv deleted the david-ci-no-inplace branch February 12, 2024 23:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
None yet
4 participants