Skip to content

fix(CodeTree/Tree): improve accessibility #4945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

fix(CodeTree/Tree): improve accessibility #4945

merged 2 commits into from
Sep 11, 2025
+295 −260

Conversation

@benjamincanac
Copy link
Member

@benjamincanac benjamincanac commented Sep 11, 2025 •
edited
Loading

🔗 Linked issue

nuxt/nuxt.com#2035

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the v4 #4488 label Sep 11, 2025
@benjamincanac benjamincanac mentioned this pull request Sep 11, 2025
Closed
8 tasks
@benjamincanac
Copy link
Member Author

benjamincanac commented Sep 11, 2025

@HugoRCD Can you confirm this fixes the lighthouse score on nuxt.com?

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 11, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4945

commit: 664f33c

@HugoRCD
Copy link
Member

HugoRCD commented Sep 11, 2025

@HugoRCD Can you confirm this fixes the lighthouse score on nuxt.com?

(SEO is low because of the blocked indexing in the preview environment)
CleanShot 2025-09-11 at 10 31 41@2x

@benjamincanac benjamincanac marked this pull request as ready for review September 11, 2025 09:45
@benjamincanac benjamincanac merged commit 117b4b3 into v4 Sep 11, 2025
14 checks passed
@benjamincanac benjamincanac deleted the fix/tree-a11y branch September 11, 2025 10:08
@benjamincanac benjamincanac mentioned this pull request Oct 9, 2025
Merged
8 tasks
benjamincanac added a commit that referenced this pull request Oct 9, 2025
@benjamincanac
fix(CodeTree/Tree): restore item wrapper with presentation role
70aaf4a 
This partially reverts #4945 as it was breaking focus navigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HugoRCD HugoRCD HugoRCD approved these changes

Assignees

No one assigned

Labels

v4 #4488

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benjamincanac @HugoRCD