fix(CodeTree): improve a11y #4938
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
OrbisK
reviewed
Sep 10, 2025
| :items="items" | ||
| :get-key="(item) => item.path" | ||
| :default-expanded="expanded" | ||
| aria-label="File tree navigation" |
There was a problem hiding this comment.
Is this one really necessary? This would need to be translated 🤔
Comment on lines
+197
to
+198
| as="ul" | ||
| role="tree" |
There was a problem hiding this comment.
I believe those are unnecessary and already done by the TreeRoot.
| <button :class="ui.link({ class: props.ui?.link, active: isSelected })"> | ||
| <button | ||
| :class="ui.link({ class: props.ui?.link, active: isSelected })" | ||
| :aria-expanded="item.children?.length ? isExpanded : undefined" |
There was a problem hiding this comment.
This is also already done
| role="treeitem" | ||
| :aria-level="level + 1" | ||
| :class="level > 0 ? ui.itemWithChildren({ class: props.ui?.itemWithChildren }) : ui.item({ class: props.ui?.item })" | ||
| :aria-selected="model?.path === item.path" |
There was a problem hiding this comment.
This is already on the button.
| <li | ||
| v-for="(item, index) in items" | ||
| :key="`${level}-${index}`" | ||
| role="treeitem" |
There was a problem hiding this comment.
This is already on the button.
|
Closing in favor of #4945. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Relates nuxt/nuxt.com#2035
❓ Type of change
📚 Description
📝 Checklist