-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows pathing issue on dev / build #684
Comments
The same, Windows 11. I've tried npm and pnpm. |
I will raise my comment from #681 here again. We had the same issue with Windows reading URL schemas differently then Mac or Linux. If it helps you can see how we approached the fix here: |
In my case it's windows 10 21H2 Based on the above comments I'm guessing there's a
similar to what's already done in the nuxt.config.ts |
@grbd ; I've published this commit Tahul/pinceau@5a8b4e9 I was using resolve from This might help on this issue, could you try reinstalling all dependencies with fresh lockfile? Not sure this will help but it is first step. Thanks 🙏 |
I tried doing a fresh clone to avoid any cache's or lock files being an issue
Then a Error is still
|
I'm afraid we'll have to wait for me to have access to a Windows environment. Thank you so much for the quick answer though. I hope to fix this tomorrow, without being able to track which line throws this error I won't be able to fix this. |
Nuxt/i18n had the same issue recently nuxt-modules/i18n#1518 They change the absolute path by a relative path with an assert type. Hope it can help you |
Just spotted a few places its showing up in the generated files under the .nuxt build directory
import { defuFn } from 'C:/D/Temp/18/test3/docus/node_modules/defu/dist/defu.mjs'
const inlineConfig = {}
import cfg0 from "C:/D/Temp/18/test3/docus/.docs/app.config.ts"
import cfg1 from "C:/D/Temp/18/test3/docus/app.config.ts"
import cfg2 from "C:/D/Temp/18/test3/docus/node_modules/@nuxt-themes/typography/app.config.ts"
export default defuFn(cfg0, cfg1, cfg2, inlineConfig)
...
import _OxsnGi2RuD from 'C:/D/Temp/18/test3/docus/node_modules/pinceau/dist/nitro';
... an entry within
...
import _OxsnGi2RuD from 'C:/D/Temp/18/test3/docus/node_modules/pinceau/dist/nitro';
... all of these actually need to be |
Hey @grbd ; That is immensely helpful, I suggest there is some issues in path resolving upstream. @danielroe ; I've only identified this line in Nitro that seem not to use Any idea on what could be the source of this? I would happily work on a PR to solve it. Here is some code pointers that might help on digging:
In the meantime I'm afraid I'll have to suggest running it in WSL. |
Windows pathing issue on dev / build nuxt-themes#684 nuxt-themes#684 This is partial fix for windows problem
After fix #686 at https://github.com/nuxt-themes/docus/blob/dev/app/module.ts#L5 |
So for the plugin line // I tried swapping
nuxt.options.nitro.plugins.push(modulePath.resolve('./nitro'))
// with an absolute path
nuxt.options.nitro.plugins.push('file:///C:/D/SourceCode/Forks/pinceau/dist/nitro') However the path then ends up getting treated as a relative path and gets a bit mangled So the next question is whereabouts it's getting parsed ether in nuxt or nitro |
Update, commenting that one line that adds the pinceau nitro plugin Allows us to get some semblence of an output we can preview
But dev just hangs (probably because we're missing the plugin)
I think the issue is someplace within nitro, I finally managed to get the depends to build and link together so more digging required. |
@grbd ; are you saying the build passes with |
Only if that line is commented out which removes the nitro plugin but that's not really a fix just an observation
Not sure if there's a better way but overall it gets us a little bit further along After the above this then leads to some sort of issue with the way a nuxt module is being imported
which I think is another nitro plugin issue (there's two one for pinceau which seems to work ok after the above fixes and a 2nd one associated with nuxtjs color-mode causing this problem) |
I'm encountering the same issue using |
i also encountered the same problem |
Same here with win10 |
Hey :) Could you try regenerating your lockfiles to grab latest version of Pinceau, using Docus ^1.0.1? I finally had access to a Windows dev environment and fixed it today! @sdsoldi @osmandlsmn @florian-lefebvre @grbd @zoey-kaiser @rekryt ; let me know if it solves your issues :) |
@Tahul , yes, everything is fine, thank you!!👍 |
Same here 👍 |
Very cool works like a charm checked build, dev, preview |
Working on win10. thank you!! 👏 |
So happy it fixed it for all of you, have fun documenting! 🙂 |
Hi,
It looks as if there's an issue when running
yarn dev
oryarn build
under windowsSeems to be some sort of pathing issue
I think it's related to the drive letter C: or D: in the path, although I've not been able to tie down exactly which bit of code is the problem.
It's the same issue mentioned here #681 by KyleRicardo
someone else also mentioned it here - nuxt-themes/docus-docs-starter#7
The text was updated successfully, but these errors were encountered: