-
Couldn't load subscription status.
- Fork 8
feat: NFD local feature discovery for aws placement groups #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
048606d to
2e1c523
Compare
dkoshkin
approved these changes
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor comments, but really liking the use of NFD here!
pkg/handlers/aws/mutation/placementgroupnfd/embedded/placementgroup_discovery.sh
Show resolved
Hide resolved
pkg/handlers/aws/mutation/placementgroupnfd/embedded/placementgroup_discovery.sh
Show resolved
Hide resolved
2e1c523 to
4868ee0
Compare
4868ee0 to
6e5787a
Compare
prajnutanix
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
NOTE: This PR stacked on CAPA fork upgrade PR #1360 . once this is merged, I will rebase it.
Automatically label nodes with placement group and partition id using node feature discovery local feature
When user provides existing placement group when creating AWS or EKS cluster, A NFD source script will be dropped in
/etc/kubernetes/node-feature-discovery/source.d/placementgroup_discovery.shon the node using cloud-init.Cloud-init then executes this script during node initialization. which will eventually create a file with feature labels in
/etc/kubernetes/node-feature-discovery/features.d/placementgroupNFD Daemon on each node will read this file to set/remove labels on the Node object.
Applications can use this information to make node aware scheduling decisions.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Currently tested manually and with unit tests. We will add e2e tests support for EKS.
Special notes for your reviewer: