-
Notifications
You must be signed in to change notification settings - Fork 8
fix: update CAPA to v2.10.0-ncn.1 #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
approved these changes
Oct 22, 2025
dlipovetsky
approved these changes
Oct 23, 2025
supershal
added a commit
that referenced
this pull request
Oct 29, 2025
**What problem does this PR solve?**: NOTE: This PR stacked on CAPA fork upgrade PR #1360 . once this is merged, I will rebase it. - Automatically label nodes with placement group and partition id using node feature discovery local feature - When user provides existing placement group when creating AWS or EKS cluster, A NFD source script will be dropped in `/etc/kubernetes/node-feature-discovery/source.d/placementgroup_discovery.sh` on the node using cloud-init. Cloud-init then executes this script during node initialization. which will eventually create a file with feature labels in `/etc/kubernetes/node-feature-discovery/features.d/placementgroup` NFD Daemon on each node will read this file to set/remove labels on the Node object. Applications can use this information to make node aware scheduling decisions. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> Currently tested manually and with unit tests. We will add e2e tests support for EKS. - cluster.yaml ``` apiVersion: cluster.x-k8s.io/v1beta1 kind: Cluster metadata: annotations: preflight.cluster.caren.nutanix.com/skip: all labels: cluster.x-k8s.io/provider: eks name: shalin-eks spec: topology: class: eks-quick-start controlPlane: metadata: annotations: controlplane.cluster.x-k8s.io/skip-kube-proxy: "" variables: - name: clusterConfig value: addons: clusterAutoscaler: {} cni: provider: Cilium csi: defaultStorage: provider: aws-ebs storageClassConfig: default providers: aws-ebs: storageClassConfigs: default: {} snapshotController: {} nfd: {} kubeProxy: mode: disabled eks: region: us-west-2 version: v1.34.1 workers: machineDeployments: - class: default-worker metadata: annotations: cluster.x-k8s.io/cluster-api-autoscaler-node-group-max-size: "1" cluster.x-k8s.io/cluster-api-autoscaler-node-group-min-size: "1" name: md-0 variables: overrides: - name: workerConfig value: eks: instanceType: m5.2xlarge placementGroup: name: eks-cn-aos ``` - Inspect labels on the nodes ``` > kubectl get nodes --kubeconfig shalin-eks.conf -o yaml | grep placement feature.node.kubernetes.io/aws-placement-group: eks-cn-aos > kubectl get nodes --kubeconfig shalin-eks.conf -o yaml | grep partition feature.node.kubernetes.io/partition: "1" ``` **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
Merged
supershal
added a commit
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ## 0.36.0 (2025-10-28) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: update Nutanix CSI to 3.3.8 by @prajnutanix in #1320 * feat: update all addon versions by @dkoshkin in #1352 * feat: deploy AWS Load Balancer controller in EKS clusters by @dkoshkin in #1341 * feat: NFD local feature discovery for aws placement groups by @supershal in #1363 ### Fixes 🔧 * fix: update CAPA to v2.10.0-ncn.1 by @supershal in #1360 * fix: skip syncing controlplane's infrastructure templates for EKS Clusterclass by @supershal in #1366 ### Other Changes * build: handle missing creds Secrets listing CSI images by @dkoshkin in #1359 * build: fix list-images for AWS LB controller by @dkoshkin in #1364 **Full Changelog**: v0.35.1...v0.36.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Upgrade CAPA fork https://github.com/nutanix-cloud-native/cluster-api-provider-aws to v2.10.0-ncn.1
How Has This Been Tested?:
Special notes for your reviewer: