feat: additionalTags handlers for AWS and EKS #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/feat-aws-eks-tags
branch
from
a1cfdd4 to
1cf378b
Compare
faiq
approved these changes
Oct 2, 2025
Merged
faiq
added a commit
that referenced
this pull request
Oct 2, 2025
🤖 I have created a release *beep* *boop* --- ## 0.35.0 (2025-10-02) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: enable Cilium source IP preservation by @dkoshkin in #1295 * feat: update capa with nutanix fork by @faiq in #1329 * feat: additionalTags handlers for AWS and EKS by @dkoshkin in #1333 ### Fixes 🔧 * fix: use nodeadm mutations by @faiq in #1332 ### Other Changes * build: downgrade clusterctl version by @dkoshkin in #1330 **Full Changelog**: v0.34.0...v0.35.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
vijayaraghavanr31
pushed a commit
that referenced
this pull request
Oct 8, 2025
**What problem does this PR solve?**:
Add support to set `additionalTags` at both the global level and for
individual nodepools.
**Which issue(s) this PR fixes**:
Fixes #
**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->
Added unit tests.
Also tested in an EKS cluster with
```
variables:
- name: clusterConfig
value:
eks:
additionalTags:
Team: nkp
IsItOverridable: "no"
name: md-0
...
workers:
machineDeployments:
- class: default-worker
variables:
overrides:
- name: workerConfig
value:
eks:
instanceType: m5.2xlarge
additionalTags:
NodeType: worker
IsItOverridable: "yes"
```
See tags added to the VPC and all other resources being created:
<img width="329" height="253" alt="Screenshot 2025-09-30 at 4 59 40 PM"
src="https://github.com/user-attachments/assets/58f474ae-685b-4908-b595-c5d2e6991b57"
/>
See tags added to the instances, notice how the `IsItOverridable` tag
comes from the higher precedence `workerConfig`
<img width="484" height="362" alt="Screenshot 2025-09-30 at 5 00 18 PM"
src="https://github.com/user-attachments/assets/09c9bcc5-9705-4d14-b922-025a167ce5e1"
/>
**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
vijayaraghavanr31
pushed a commit
that referenced
this pull request
Oct 8, 2025
🤖 I have created a release *beep* *boop* --- ## 0.35.0 (2025-10-02) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: enable Cilium source IP preservation by @dkoshkin in #1295 * feat: update capa with nutanix fork by @faiq in #1329 * feat: additionalTags handlers for AWS and EKS by @dkoshkin in #1333 ### Fixes 🔧 * fix: use nodeadm mutations by @faiq in #1332 ### Other Changes * build: downgrade clusterctl version by @dkoshkin in #1330 **Full Changelog**: v0.34.0...v0.35.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Add support to set
additionalTagsat both the global level and for individual nodepools.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Added unit tests.
Also tested in an EKS cluster with
See tags added to the VPC and all other resources being created:
See tags added to the instances, notice how the
IsItOverridabletag comes from the higher precedenceworkerConfigSpecial notes for your reviewer: