Skip to content

fix: use nodeadm mutations #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 2, 2025
Merged

fix: use nodeadm mutations #1332

merged 5 commits into from
Oct 2, 2025

Conversation

@faiq
Copy link
Contributor

@faiq faiq commented Sep 30, 2025 •
edited
Loading

What problem does this PR solve?:
stacked on #1329 to use nodeadm in handlers

Which issue(s) this PR fixes:
https://jira.nutanix.com/browse/NCN-110198

How Has This Been Tested?:

Special notes for your reviewer:

@github-actions github-actions bot added the fix label Sep 30, 2025
@faiq faiq force-pushed the faiq/update-capa-with-fork branch from eee70a9 to bced2a6 Compare September 30, 2025 22:02
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch 2 times, most recently from 58c3aa8 to b0747d5 Compare September 30, 2025 23:17
@github-actions github-actions bot added fix and removed fix labels Sep 30, 2025
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch 2 times, most recently from 22d1c24 to 7521958 Compare October 1, 2025 00:01
jimmidyson
jimmidyson reviewed Oct 1, 2025
View reviewed changes
@dkoshkin
Copy link
Contributor

dkoshkin commented Oct 1, 2025

The ClusterClass and example Cluster don't set this config, I'm ok if we update the ClusterClass in a follow up. We will need additional changes to set instanceMetadataOptions too.

@faiq faiq force-pushed the faiq/update-capa-with-fork branch from bced2a6 to a7b9f48 Compare October 1, 2025 16:44
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch 4 times, most recently from 40ea414 to d1dc59e Compare October 1, 2025 17:14
@faiq faiq force-pushed the faiq/update-capa-with-fork branch from a7b9f48 to fd6f006 Compare October 1, 2025 17:16
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch from d1dc59e to ad37139 Compare October 1, 2025 17:18
@faiq faiq mentioned this pull request Oct 1, 2025
Merged
@faiq faiq force-pushed the faiq/update-capa-with-fork branch from fd6f006 to bdbb3dc Compare October 1, 2025 19:54
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch 3 times, most recently from 7185ec7 to 520c91a Compare October 1, 2025 21:13
@faiq faiq force-pushed the faiq/update-capa-with-fork branch from bdbb3dc to 418f6d5 Compare October 1, 2025 21:14
Base automatically changed from faiq/update-capa-with-fork to main October 1, 2025 22:49
@github-actions github-actions bot added fix and removed fix labels Oct 1, 2025
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch from 520c91a to 6cc632e Compare October 1, 2025 22:52
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch from 6cc632e to 9592e74 Compare October 1, 2025 22:57
faiq added a commit that referenced this pull request Oct 1, 2025
@faiq
fix: adds ami details for nodeadm configs (#1334)
6a01f27 
**What problem does this PR solve?**:
adds details required for al 2023 

**Which issue(s) this PR fixes**:
stacked on #1332 

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
faiq added a commit that referenced this pull request Oct 1, 2025
@faiq
fix: adds ami details for nodeadm configs (#1334)
48bf4c4 
**What problem does this PR solve?**:
adds details required for al 2023

**Which issue(s) this PR fixes**:
stacked on #1332

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch from 6a01f27 to 48bf4c4 Compare October 1, 2025 23:14
faiq added a commit that referenced this pull request Oct 1, 2025
@faiq
fix: adds ami details for nodeadm configs (#1334)
275105d 
**What problem does this PR solve?**:
adds details required for al 2023

**Which issue(s) this PR fixes**:
stacked on #1332

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch from 48bf4c4 to 275105d Compare October 1, 2025 23:19
@dkoshkin
Copy link
Contributor

dkoshkin commented Oct 1, 2025

Tried creating a cluster with the default example

I1001 23:41:17.514359       1 nodeadmconfig_controller.go:189] "Generating userdata" controller="nodeadmconfig" controllerGroup="bootstrap.cluster.x-k8s.io" controllerKind="NodeadmConfig" NodeadmConfig="default/dk-al2023-md-0-hm7pr-zsn2l-xjln4" namespace="default" name="dk-al2023-md-0-hm7pr-zsn2l-xjln4" reconcileID="32d4385b-d1f8-4a2a-8db1-db02788e6d1c"
I1001 23:41:17.514699       1 nodeadmconfig_controller.go:246] "Generating nodeadm userdata" controller="nodeadmconfig" controllerGroup="bootstrap.cluster.x-k8s.io" controllerKind="NodeadmConfig" NodeadmConfig="default/dk-al2023-md-0-hm7pr-zsn2l-xjln4" namespace="default" name="dk-al2023-md-0-hm7pr-zsn2l-xjln4" reconcileID="32d4385b-d1f8-4a2a-8db1-db02788e6d1c" cluster="default_dk-al2023-l4cgg" endpoint="https://44B1B6136CF65592378DCFF0A6B9F1F1.gr7.us-west-2.eks.amazonaws.com"
E1001 23:41:17.514788       1 nodeadmconfig_controller.go:252] "Failed to create a worker join configuration" err="failed to execute node config template: template: node:42:9: executing \"node\" at <.Instance>: can't evaluate field Instance in type *userdata.NodeadmInput" controller="nodeadmconfig" controllerGroup="bootstrap.cluster.x-k8s.io" controllerKind="NodeadmConfig" NodeadmConfig="default/dk-al2023-md-0-hm7pr-zsn2l-xjln4" namespace="default" name="dk-al2023-md-0-hm7pr-zsn2l-xjln4" reconcileID="32d4385b-d1f8-4a2a-8db1-db02788e6d1c"
E1001 23:41:17.515096       1 controller.go:347] "Reconciler error" err="failed to execute node config template: template: node:42:9: executing \"node\" at <.Instance>: can't evaluate field Instance in type *userdata.NodeadmInput" controller="nodeadmconfig" controllerGroup="bootstrap.cluster.x-k8s.io" controllerKind="NodeadmConfig" NodeadmConfig="default/dk-al2023-md-0-hm7pr-zsn2l-xjln4" namespace="default" name="dk-al2023-md-0-hm7pr-zsn2l-xjln4" reconcileID="32d4385b-d1f8-4a2a-8db1-db02788e6d1c"

@faiq
Copy link
Contributor Author

faiq commented Oct 1, 2025

thats not good. its going to require a rerelease of CAPA :(

jimmidyson
jimmidyson reviewed Oct 2, 2025
View reviewed changes
@faiq
fix: adds ami details for nodeadm configs (#1334)
5556b02 
**What problem does this PR solve?**:
adds details required for al 2023

**Which issue(s) this PR fixes**:
stacked on #1332

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
@faiq faiq force-pushed the faiq/nodeadm-config-mutations branch from 275105d to 5556b02 Compare October 2, 2025 17:02
@faiq
Copy link
Contributor Author

faiq commented Oct 2, 2025 

11:11 AM  fraza @ Linux-PC1RG42G  ~/go/src/github.com/nutanix-cloud-native/cluster-api-runtime-extensions-nutanix  faiq/nodeadm-config-mutations? 
$ clusterctl describe cluster -c faiqeks
NAME                                                       READY  SEVERITY  REASON  SINCE  MESSAGE 
Cluster/faiqeks                                            True                     16m             
├─ClusterInfrastructure - AWSManagedCluster/faiqeks-rc8qr                                           
├─ControlPlane - AWSManagedControlPlane/faiqeks-8slch      True                     16m             
└─Workers                                                                                           
  └─MachineDeployment/faiqeks-md-0-96vvt                   True                     16m             
    └─Machine/faiqeks-md-0-96vvt-x7tpl-7bkjj               True                     16m  
    ```

@faiq faiq enabled auto-merge (squash) October 2, 2025 18:33
@faiq faiq merged commit 5cfe9ea into main Oct 2, 2025
37 of 38 checks passed
@faiq faiq deleted the faiq/nodeadm-config-mutations branch October 2, 2025 18:46
@faiq faiq mentioned this pull request Oct 2, 2025
Merged
faiq added a commit that referenced this pull request Oct 2, 2025
@faiq
release(main): v0.35.0 (#1335)
f9e3423 
🤖 I have created a release *beep* *boop*
---


## 0.35.0 (2025-10-02)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: enable Cilium source IP preservation by @dkoshkin in
#1295
* feat: update capa with nutanix fork by @faiq in
#1329
* feat: additionalTags handlers for AWS and EKS by @dkoshkin in
#1333
### Fixes 🔧
* fix: use nodeadm mutations by @faiq in
#1332
### Other Changes
* build: downgrade clusterctl version by @dkoshkin in
#1330


**Full Changelog**:
v0.34.0...v0.35.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
vijayaraghavanr31 pushed a commit that referenced this pull request Oct 8, 2025
@faiq @vijayaraghavanr31
fix: use nodeadm mutations (#1332)
6e01788 
**What problem does this PR solve?**:
stacked on #1329 to use nodeadm in handlers 

**Which issue(s) this PR fixes**:
https://jira.nutanix.com/browse/NCN-110198

**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->

**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
vijayaraghavanr31 pushed a commit that referenced this pull request Oct 8, 2025
@faiq @vijayaraghavanr31
release(main): v0.35.0 (#1335)
bb9d836 
🤖 I have created a release *beep* *boop*
---


## 0.35.0 (2025-10-02)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: enable Cilium source IP preservation by @dkoshkin in
#1295
* feat: update capa with nutanix fork by @faiq in
#1329
* feat: additionalTags handlers for AWS and EKS by @dkoshkin in
#1333
### Fixes 🔧
* fix: use nodeadm mutations by @faiq in
#1332
### Other Changes
* build: downgrade clusterctl version by @dkoshkin in
#1330


**Full Changelog**:
v0.34.0...v0.35.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmidyson jimmidyson jimmidyson left review comments

@dkoshkin dkoshkin dkoshkin approved these changes

@supershal supershal supershal approved these changes

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@faiq @dkoshkin @jimmidyson @supershal