Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/ipc redux #702

Merged
merged 9 commits into from
Apr 25, 2020
Merged

Feat/ipc redux #702

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6c124eb
feat(redux): send ipc event via a middleware
Apr 20, 2020
31ea5b9
refactor(ipc): move ipc related code to app package
Apr 21, 2020
66c8079
fix(ipc): avoid sending useless ipc events
Apr 21, 2020
3fdf1ae
refactor(ipc): move download ipc code in ipc middleware
Apr 21, 2020
0a847ff
fix(discord): better discord and mpris integration
Apr 21, 2020
9a53a6e
fix(mpris): add check in playpause handler
Apr 22, 2020
ca05486
fix(store): add back restart api and stop api events
Apr 22, 2020
c6cc90b
refactor(ipc): use an enum for ipc events name
Apr 22, 2020
d8c2d4b
refactor(ipc): move window ipc events in ipc middleware
Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(store): add back restart api and stop api events
  • Loading branch information
Charles Jacquin committed Apr 22, 2020
commit ca05486d5a361ee7d00cfa4994618c66e9abe09e
6 changes: 3 additions & 3 deletions packages/core/src/persistence/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import _ from 'lodash';
import ElectronStore from 'electron-store';
import { ipcRenderer } from 'electron';

import { settingsConfig } from '../settings';
import { restartApi, stopApi } from '../mpris';

/**
* return multiple items from store
Expand Down Expand Up @@ -83,9 +83,9 @@ function setOption(key, value) {
(key === 'api.port' && isValidPort(value) && getOption('api.enabled')) ||
(key === 'api.enabled' && value)
) {
restartApi();
ipcRenderer.send('restart-api');
} else if (key === 'api.enabled' && !value) {
stopApi();
ipcRenderer.send('stop-api');
}
}

Expand Down