Feat/ipc redux #702
Merged
Feat/ipc redux #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 22, 2020 10:43
|
Wow what a fantastic contribution. It was a long time coming. It's so neat and ordered now it makes it way easier to maintain and use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a ipc middleware to redux store, its role is to send ipc events. This way, redux actions are independant of electron (we should probably do something similar for electron-store).
This PR also optimize ipc exchange for volume and playpause events.
before:
mpris => main => renderer => main
now:
mpris => main => renderer
I also remove mpris.js in core package.
all ipcRenderer related code is now located in ipcContainer and ipcMiddleware.
All events name are defined in an enum in core package.