Fix missing ValidatorMessage stub in Python bindings
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 19.50% 19.50%
=======================================
Files 17 17
Lines 3214 3214
=======================================
Hits 627 627
Misses 2587 2587 |
|
An API is changing, so should the Changelog be updated? |
derekpierre
reviewed
Jun 21, 2023
CHANGELOG.md
Outdated
| @@ -9,9 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Fixed | |||
|
|
|||
| - Fixed a typo in the Python type stubs for `ferveo.Keypair.secure_randomness_size()`. ([#61]) | |||
| - Replaced raw tuples with `ValidatorMessage` in Python bindings. ([ferveo#131]) | |||
There was a problem hiding this comment.
i.e. major version change...?
I think your changelog entries should be under 0.10.0 because of the breaking change.
There was a problem hiding this comment.
They should be under ### Changed subsection, not ### Fixed.
piotr-roslaniec
force-pushed
the
ferveo#131
branch
5 times, most recently
from
6c5f6cc
to
6bea0ba
Compare
|
Fixed & rebased |
|
Needs another rebase now that #63 has been merged. |
piotr-roslaniec
force-pushed
the
ferveo#131
branch
from
b1bf177
to
a077cd0
Compare
|
Rebased again. Added a small, unrelated change related to the previous PR that I didn't catch. |
|
@piotr-roslaniec I thought we weren't merging with github dependencies? |
|
@derekpierre, Yes, my bad, I will replace it with a new release nucypher/ferveo#132 shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
ValidatorMessagetype in Python BindingsIssues fixed/closed:
AggregatedTranscript()signature incorrect in.pyiferveo#129ferveo-pre-release@0.1.0-alpha.9#62Why it's needed:
.pyistubs ferveo#131Notes for reviewers:
ferveoversionferveo-pre-release@0.1.0-alpha.9#62 since theferveoversion used is the child of the changes mentioned in the issue