-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect signatures in .pyi
stubs
#131
Conversation
Codecov Report
@@ Coverage Diff @@
## fix-dkg-pk-deser-wasm #131 +/- ##
=========================================================
- Coverage 78.78% 78.66% -0.12%
=========================================================
Files 24 24
Lines 4869 4880 +11
=========================================================
+ Hits 3836 3839 +3
- Misses 1033 1041 +8
|
578a930
to
69d5a77
Compare
If this is will affect No use in merging/releasing this code etc. to then catch problems in |
Although I guess it looks like this goes into a feature branch |
b7d62ba
to
3863842
Compare
@derekpierre My plan was to create a PR from Illustrating the idea: Order of feedback: |
Perfect 👌 !
Order of merging the PRs once reviewed and working would be:
|
69d5a77
to
4aeda15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👨🏻🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
Type of PR:
Required reviews:
What this does:
ValidatorMessage
in Python bindings.pyi
file, examples, etc.Issues fixed/closed:
AggregatedTranscript()
signature incorrect in.pyi
#129Why it's needed:
Notes for reviewers:
DkgPublicKey
byte serialization #128ValidatorMessage
stub in Python bindings nucypher-core#65