Skip to content

Conversation

@derekpierre
Copy link
Member

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

Add tests for threshold multisig.

Issues fixed/closed:

  • Fixes #...

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:

What should reviewers focus on?
Is there a particular commit/function/section of your PR that requires more attention from reviewers?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive test coverage for the ThresholdSigningMultisig contract, which implements a multi-signature wallet with ERC-1271 signature validation.

Key changes:

  • Adds 10 test functions covering initialization, signer management, threshold configuration, authorization checks, and signature validation
  • Tests both individual operations (add/remove/replace signers) and bulk updates with and without full signer replacement
  • Validates signature verification logic including edge cases and invalid scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@vzotova vzotova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@derekpierre derekpierre merged commit 40100e8 into nucypher:signing Nov 12, 2025
2 checks passed
@derekpierre derekpierre mentioned this pull request Nov 12, 2025
23 tasks
derekpierre added a commit that referenced this pull request Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants