[EPIC] Signing Infra #383
Draft
[EPIC] Signing Infra #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekpierre
changed the title
derekpierre
changed the title
derekpierre
force-pushed
the
signing
branch
2 times, most recently
from
5d47a0f to
f6ac21b
Compare
… SigningCoordinator contract.
…or cohort participant.
…note this is specific to the same chain as the signing coordinator.
…s are not allowed.
…being invalid - need to improve upgrade process through reinitializers next time.
…e on Ethereum with SigningCoordinatorChild contracts on L2s.
…olia <-> Base Sepolia.
…t was already previously deployed.
…did not update old SigningCoordinatorChild which became out of sync with new SigningCoordinator. Really the entire infra needed to be fully deployed again i.e. everything started from scratch. Since the contracts are now properly proxied, upgrading will be easier moving forward.
…address when registering and the chain is the current chain. Add tests for SigningCoordinatorDispatcher.
Revamped `lynx` contract deployments for signing infrastructure
`ThresholdSigningMultisig` tests
More testing of Signing Contracts
…e is no need to have a set function and associated event.
Deploy Tapir Signing Infra
Note that ownership of contracts are currently the nuco-deployer and not the NUCO multisig, and the admin role for SigningCoordinator is the nuco-deployer - this needs to be done when testing is completed.
Note that owner of contracts is currently the nuco-deployer and not the NUCO multisig - this needs to be done when testing is completed.
…g deployment (see individual prior commits). We can't set ownership to NuCo multisig during deployment because this would make testing harder. Once testing is completed then ownership will be transferred.
Mainnet Signing Infra Scripts/Deployment
…ked nodes (no sampling as yet since only specific experimental nodes are running with signing functionality).
Update signing cohort formation script to work on `mainnet`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
lynxcontract deployments for signing infrastructure #441ThresholdSigningMultisigtests #442mainnet. #448Issues fixed/closed:
Why it's needed:
Notes for reviewers: