Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ir/config: Fix unenforced morph.consensus.p2p.peers.min config default #2856

Merged
merged 1 commit into from
May 26, 2024

Commits on May 24, 2024

  1. ir/config: Fix unenforced morph.consensus.p2p.peers.min config default

    As declared in NeoFS IR configuration, min required number of peer
    connections must default to ⌈2/3N-1⌉. Previously, IR app did not set
    default value when `p2p` and/or `p2p.peers` sections were omitted, only
    when `p2p.peers` is presented and `min` value is missing. This was
    incorrect and also unresponsive to the admin: a forgotten value
    setting had the effect of no consensus and no new blocks.
    
    This fixes the behavior: now value is recalculated in any setting
    without a field. Note that while explicitly specifying zero is
    problematic in general, it does not default to preserve admin intent.
    
    Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
    cthulhu-rider committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3930c67 View commit details
    Browse the repository at this point in the history