ir/config: Fix unenforced morph.consensus.p2p.peers.min config default
#2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2856 +/- ##
==========================================
+ Coverage 23.63% 23.65% +0.01%
==========================================
Files 770 770
Lines 44506 44510 +4
==========================================
+ Hits 10519 10527 +8
+ Misses 33132 33129 -3
+ Partials 855 854 -1 ☔ View full report in Codecov by Sentry. |
evgeniiz321
approved these changes
May 23, 2024
As declared in NeoFS IR configuration, min required number of peer connections must default to ⌈2/3N-1⌉. Previously, IR app did not set default value when `p2p` and/or `p2p.peers` sections were omitted, only when `p2p.peers` is presented and `min` value is missing. This was incorrect and also unresponsive to the admin: a forgotten value setting had the effect of no consensus and no new blocks. This fixes the behavior: now value is recalculated in any setting without a field. Note that while explicitly specifying zero is problematic in general, it does not default to preserve admin intent. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
bugfix/ir-config-default
branch
from
438171f
to
3930c67
Compare
cthulhu-rider
added
bug
carpawell
approved these changes
May 24, 2024
roman-khimov
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @evgeniiz321
following P2P config
led to no consensus for 4x setup although it should have. Making it
fixed the problem. Thus, the declared default was not fulfilled
neofs-node/config/example/ir.yaml
Lines 76 to 78 in 9a9a5d5