-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WIF and NEP2 support in --wallet argument #1789
Remove WIF and NEP2 support in --wallet argument #1789
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
- Coverage 33.48% 33.41% -0.07%
==========================================
Files 353 352 -1
Lines 23982 23962 -20
==========================================
- Hits 8030 8008 -22
- Misses 15286 15287 +1
- Partials 666 667 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could you, please, add a commit sign-off? We have a CI step that has failed in that PR.
- We also should fix the flag description. E.g.
neofs-cli container create -h
:-w, --wallet string WIF (NEP-2) string or path to the wallet or binary key
- It is common practice to write commit msg imperatively:
Removed
->Remove
.
Please avoid merge commits at rebase at all cost. |
@acid-ant, for future: we also try to keep CHANGELOG.md in an actual state after every PR. |
Is there a related issue? If not, could you please take care of labels and projects? |
This is a related issue #1128 |
Updated. Please review. |
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
Closes: #1128