Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WIF support in --wallet argument #1128

Closed
532910 opened this issue Feb 1, 2022 · 4 comments · Fixed by #1789
Closed

Remove WIF support in --wallet argument #1128

532910 opened this issue Feb 1, 2022 · 4 comments · Fixed by #1789
Assignees
Labels
good first issue Good for newcomers neofs-cli NeoFS CLI application issues
Milestone

Comments

@532910
Copy link

532910 commented Feb 1, 2022

I believe there should be no way to pass a sensitive data as a command line argument.

@532910 532910 added the triage label Feb 1, 2022
@alexvanin
Copy link
Contributor

--wif is removed in v0.27.5. You still able to provide WIF with --wallet but it is less encouraged this way. Indeed, it is not secure, but it is useful for testing (e.g. neofs-testcases uses it a lot).

Config is tightly coupled with arguments, it will be hard to keep WIF in config but remove it from arguments.

I guess we will drop WIF support completely one day.

@carpawell carpawell added the neofs-cli NeoFS CLI application issues label Aug 11, 2022
@carpawell
Copy link
Member

We are ready.

@carpawell carpawell modified the milestones: v0.32.0, v0.31.1 Aug 11, 2022
@acid-ant
Copy link
Contributor

@carpawell, @fyrchik, @realloc should we reject NEP2 together with WIF and read only from file?

@fyrchik
Copy link
Contributor

fyrchik commented Sep 14, 2022

I think NEP2 support can also be dropped, I haven't never seen it being actually used anywhere.

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers neofs-cli NeoFS CLI application issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants