-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify custom signer scope for morph invocations #1124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 35.56% 35.48% -0.09%
==========================================
Files 285 285
Lines 17936 17971 +35
==========================================
- Hits 6379 6377 -2
- Misses 11074 11112 +38
+ Partials 483 482 -1
Continue to review full report at Codecov.
|
"github.com/spf13/viper" | ||
) | ||
|
||
const contractWalletName = "contract.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be more clear I'd name it
const contractWalletName = "contract.json" | |
const contractWalletFilename = "contract.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
} | ||
|
||
var password string | ||
if key := "credentials.contract"; viper.IsSet(key) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems similar to code block in initializeManifestWallet
, maybe unify them?
Btw key
can be const
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on neofs-contract v0.14.2 with group.neofs
NNS record and on v0.14.0 without NNS record. With requested fix works fine.
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
…function Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Related #749 .