Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CustomGroup scope for side chain contract invocations #749

Closed
alexvanin opened this issue Aug 5, 2021 · 5 comments
Closed

Use CustomGroup scope for side chain contract invocations #749

alexvanin opened this issue Aug 5, 2021 · 5 comments
Assignees
@fyrchik
Labels
neofs-ir Inner Ring node application issues neofs-storage Storage node application issues
Milestone
v0.28.0

Comments

@alexvanin
Copy link
Contributor

Global scope is not that good even if it is used in side chain. Update neofs-contract repo with custom group scope support in manifest and specify this group scope in side chain invocation of morph client.
@roman-khimov
Copy link
Member

See contract manifest add-group command in neo-go to sign manifests (nspcc-dev/neo-go#2100).

@alexvanin
Copy link
Contributor Author

See main chain scope fix in #751

@fyrchik
Copy link
Contributor

fyrchik commented Oct 18, 2021

We currently have 2 different ways to deploy contracts: via neofs-adm and by hand (neo-preodolenie).
I propose to use the following scheme:

  1. Add has a separate wallet to sign group to both neofs-adm and neo-preodolenie.
  2. Add a keyword add_manifest_group to neo-preodolenie.
  3. Set group address in NNS similarly to contract hashes.
  4. If a group is missing from NNS fallback to Global scope.

@fyrchik
Copy link
Contributor

fyrchik commented Nov 18, 2021

It can be easier with nspcc-dev/neo-go#2251

@fyrchik fyrchik mentioned this issue Nov 29, 2021
Merged
@fyrchik fyrchik mentioned this issue Jan 29, 2022
Merged
@alexvanin
Copy link
Contributor Author

Closed in #1124

aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] neofs-adm: make alphabet size check more robust
d1c88ff 
We can now store wallet for signing manifest groups in the same dir.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] neofs-adm: include neofs contracts in a group
f7ce472 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] neofs-adm: create wallet for signing contract group
1b4609b 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] neofs-adm: save group public key in NNS
03b983f 
Query `group.neofs` instead of retrieving individual manifest.

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] neofs-adm: add group scope to force-new-epoch command
f701674 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] neofs-adm: Set signer for committee transactions
edebe12 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] morph/client: cache NNS contract hash
67c3727 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] morph/client: allow to fetch contract group key
53b46fc 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] morph/client: reuse TestInvokePrm in InvokePrm
a6e6279 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] morph/client: set group signer scope
7d19899 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Mar 5, 2022
@fyrchik @aprasolova
[nspcc-dev#749] neofs-adm: refactor password reading into a separate …
104d6b6 
…function

Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyrchik fyrchik

Labels
neofs-ir Inner Ring node application issues neofs-storage Storage node application issues
Projects
None yet
Milestone
v0.28.0
Development

No branches or pull requests
3 participants
@alexvanin @fyrchik @roman-khimov