Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

writecache: Fix repetitive BlobStor writes #1028

Merged

Conversation

cthulhu-rider
Copy link
Contributor

Writecache periodically successfully wrote the same objects to the BlobStor.

Leonard Lyubich added 2 commits December 9, 2021 15:37
Make `flushBigObjects` routine to mark objects which are written to
`BlobStor`. This prevents already flushed objects from being written on
the next iterator tick.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Make `flushBigObjects` routine to call `evictObjects` which was
successfully written to `BlobStor`.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider added bug Something isn't working neofs-storage Storage node application issues labels Dec 9, 2021
@cthulhu-rider cthulhu-rider self-assigned this Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #1028 (9d9dfa2) into master (fd321b6) will not change coverage.
The diff coverage is n/a.

❗ Current head 9d9dfa2 differs from pull request most recent head 5126617. Consider uploading reports for the commit 5126617 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1028   +/-   ##
=======================================
  Coverage   37.45%   37.45%           
=======================================
  Files         267      267           
  Lines       14301    14301           
=======================================
  Hits         5356     5356           
  Misses       8506     8506           
  Partials      439      439           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd321b6...5126617. Read the comment docs.

@alexvanin alexvanin merged commit fc42844 into nspcc-dev:master Dec 14, 2021
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
Make `flushBigObjects` routine to mark objects which are written to
`BlobStor`. This prevents already flushed objects from being written on
the next iterator tick.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
Make `flushBigObjects` routine to call `evictObjects` which was
successfully written to `BlobStor`.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider deleted the bugfix/write-cache-flush-loop branch September 30, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neofs-storage Storage node application issues U3 Regular
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants