Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writecache: Fix db counter decrement #1022

Merged
merged 1 commit into from
Dec 15, 2021
Merged

writecache: Fix db counter decrement #1022

merged 1 commit into from
Dec 15, 2021

Conversation

ZhangTao1596
Copy link
Contributor

@ZhangTao1596 ZhangTao1596 commented Dec 8, 2021 •
edited
Loading

Signed-off-by: ZhangTao1596 zhangtao@ngd.neo.org

@alexvanin

@codecov
Copy link

codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #1022 (6907775) into master (2a031c5) will not change coverage.
The diff coverage is n/a.

❗ Current head 6907775 differs from pull request most recent head 480990b. Consider uploading reports for the commit 480990b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1022   +/-   ##
=======================================
  Coverage   37.45%   37.45%           
=======================================
  Files         267      267           
  Lines       14301    14301           
=======================================
  Hits         5356     5356           
  Misses       8506     8506           
  Partials      439      439

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a031c5...480990b. Read the comment docs.

@alexvanin
Copy link
Contributor

Will be included in the patch for v0.27.0 release.

@alexvanin
Copy link
Contributor

Rebase it after #1028

cthulhu-rider
cthulhu-rider approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@cthulhu-rider cthulhu-rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhangTao1596 could you please squash your commits into a single one (with issue num)?

@ZhangTao1596
Copy link
Contributor Author

@ZhangTao1596 could you please squash your commits into a single one (with issue num)?

👌

@ZhangTao1596
[nspcc-dev#1022] writecache: Fix db counter decrement and flushed big…
480990b 
… object

Signed-off-by: ZhangTao1596 <zhangtao@ngd.neo.org>
@alexvanin alexvanin merged commit 1be0c42 into nspcc-dev:master Dec 15, 2021
@ZhangTao1596 ZhangTao1596 deleted the fix-writecache branch December 17, 2021 03:04
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
@ZhangTao1596 @aprasolova
[nspcc-dev#1022] writecache: Fix db counter decrement and flushed big…
73c1fe6 
… object

Signed-off-by: ZhangTao1596 <zhangtao@ngd.neo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthulhu-rider cthulhu-rider cthulhu-rider approved these changes

@alexvanin alexvanin alexvanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.27.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ZhangTao1596 @alexvanin @cthulhu-rider @realloc