Skip to content

Export default native contract constructors#4145

Merged
roman-khimov merged 2 commits intomasterfrom
export-default-natives
Jan 23, 2026
Merged

Export default native contract constructors#4145
roman-khimov merged 2 commits intomasterfrom
export-default-natives

Conversation

@AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Jan 23, 2026

Problem

nspcc-dev/neofs-node#3759 (comment). Metadata chain needs some of default native implementations.

Solution

Export Policy and Notary constructors. I don't want to export Neo because this implementation contains too many N3-specific mechanics which is not needed in metadata chain at all and should be mocked on the NeoFS side by custom (and simple) native Neo. Ref. nspcc-dev/neofs-node#3759 (comment).

Required for nspcc-dev/neofs-node#3759.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Required for nspcc-dev/neofs-node#3759.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@AnnaShaleva AnnaShaleva added this to the v0.117.0 milestone Jan 23, 2026
@AnnaShaleva AnnaShaleva requested a review from carpawell January 23, 2026 15:02
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.38%. Comparing base (fc4a77d) to head (6e46431).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4145      +/-   ##
==========================================
- Coverage   83.39%   83.38%   -0.02%     
==========================================
  Files         356      356              
  Lines       43146    43146              
==========================================
- Hits        35982    35976       -6     
- Misses       5407     5409       +2     
- Partials     1757     1761       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roman-khimov roman-khimov merged commit f3a4907 into master Jan 23, 2026
33 of 34 checks passed
@roman-khimov roman-khimov deleted the export-default-natives branch January 23, 2026 15:18
carpawell added a commit to nspcc-dev/neofs-node that referenced this pull request Feb 2, 2026
From neo-go side it is useful to have:
* nspcc-dev/neo-go#4117,
* nspcc-dev/neo-go#4145,
* nspcc-dev/neo-go#4118.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to nspcc-dev/neofs-node that referenced this pull request Feb 2, 2026
From neo-go side it is useful to have:
* nspcc-dev/neo-go#4117,
* nspcc-dev/neo-go#4145,
* nspcc-dev/neo-go#4118.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants