Export default native contract constructors#4145
Merged
roman-khimov merged 2 commits intomasterfrom Jan 23, 2026
Merged
Conversation
Required for nspcc-dev/neofs-node#3759. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Required for nspcc-dev/neofs-node#3759. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4145 +/- ##
==========================================
- Coverage 83.39% 83.38% -0.02%
==========================================
Files 356 356
Lines 43146 43146
==========================================
- Hits 35982 35976 -6
- Misses 5407 5409 +2
- Partials 1757 1761 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Jan 23, 2026
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Feb 2, 2026
From neo-go side it is useful to have: * nspcc-dev/neo-go#4117, * nspcc-dev/neo-go#4145, * nspcc-dev/neo-go#4118. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Feb 2, 2026
From neo-go side it is useful to have: * nspcc-dev/neo-go#4117, * nspcc-dev/neo-go#4145, * nspcc-dev/neo-go#4118. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nspcc-dev/neofs-node#3759 (comment). Metadata chain needs some of default native implementations.
Solution
Export Policy and Notary constructors. I don't want to export Neo because this implementation contains too many N3-specific mechanics which is not needed in metadata chain at all and should be mocked on the NeoFS side by custom (and simple) native Neo. Ref. nspcc-dev/neofs-node#3759 (comment).