core: export native serializators#4118
Merged
roman-khimov merged 1 commit intomasterfrom Dec 22, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4118 +/- ##
==========================================
- Coverage 83.47% 83.45% -0.02%
==========================================
Files 353 353
Lines 42821 42819 -2
==========================================
- Hits 35744 35735 -9
- Misses 5323 5330 +7
Partials 1754 1754 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
putConvertibleToDAO and getConvertibleFromDAO can be used by custom native contracts, ref. nspcc-dev/neofs-node#3742 (comment). Move these helpers to (*DAO) so that everyone can use them. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
meta-fixes
branch
from
6e013a7 to
d66a9ce
Compare
carpawell
approved these changes
Dec 22, 2025
| func (dao *Simple) PutStorageConvertible(id int32, key []byte, conv stackitem.Convertible) error { | ||
| item, err := conv.ToStackItem() | ||
| if err != nil { | ||
| return err |
Member
There was a problem hiding this comment.
i'd add context to every internal err
roman-khimov
approved these changes
Dec 22, 2025
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Dec 26, 2025
From neo-go side it is useful to have nspcc-dev/neo-go#4117 and nspcc-dev/neo-go#4118. Contracts are updated to keep deploy code buildable. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Feb 2, 2026
From neo-go side it is useful to have nspcc-dev/neo-go#4117 and nspcc-dev/neo-go#4118. Contracts are updated to keep deploy code buildable. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Feb 2, 2026
From neo-go side it is useful to have: * nspcc-dev/neo-go#4117, * nspcc-dev/neo-go#4145, * nspcc-dev/neo-go#4118. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell
added a commit
to nspcc-dev/neofs-node
that referenced
this pull request
Feb 2, 2026
From neo-go side it is useful to have: * nspcc-dev/neo-go#4117, * nspcc-dev/neo-go#4145, * nspcc-dev/neo-go#4118. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PutConvertibleToDAO and GetConvertibleFromDAO can be used by custom native contracts, ref.
nspcc-dev/neofs-node#3742 (comment).