-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(release): process project dependents in other release groups despite group filter #31273 #32826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Coly010
wants to merge
4
commits into
master
Choose a base branch
from
release/all-projects-groups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+164
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 33fc7a2
☁️ Nx Cloud last updated this comment at |
packages/nx/src/command-line/release/version/release-group-processor.spec.ts
Outdated
Show resolved
Hide resolved
5a3b008
to
08b9c3c
Compare
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1bf6c56
to
56aaacb
Compare
packages/nx/src/command-line/release/version/release-group-processor.ts
Outdated
Show resolved
Hide resolved
811c7f1
to
8fe824a
Compare
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
8fe824a
to
33fc7a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using the --groups filter with nx release, projects in other release groups that depend on
projects in the filtered group are not properly updated, even when updateDependents is set to
auto. This causes dependency version mismatches when releasing a subset of release groups.
Expected Behavior
When releasing with a --groups filter and updateDependents: 'auto', all dependent projects
across all release groups should have their dependencies updated to match the new versions of
the filtered projects being released. This ensures dependency consistency across the entire
workspace.
Related Issue(s)
Fixes #31273