fix(release): process project dependents in other release groups despite group filter #31273

Author: Coly010

packages/nx/src/command-line/release/version/release-group-processor.spec.ts

@@ -1258,6 +1258,75 @@ describe('ReleaseGroupProcessor', () => {
    * will have already been caught and handled by filterReleaseGroups(), so that is not repeated here.
    */
   describe('filters', () => {
+    it('should bump projects across release groups when one release group is selected but all projects are in nx release config', async () => {
+      const {
+        nxReleaseConfig,
+        projectGraph,
+        releaseGroups,
+        releaseGroupToFilteredProjects,
+        filters,
+      } = await createNxReleaseConfigAndPopulateWorkspace(
+        tree,
+        `
+            projectJ ({ "projectsRelationship": "independent" }):
+              - projectJ@1.0.0 [js]
+                -> depends on projectK
+            projectK ({ "projectsRelationship": "independent" }):    
+              - projectK@2.0.0 [js]
+          `,
+        {
+          version: {
+            conventionalCommits: true,
+            updateDependents: 'auto',
+          },
+        },
+        mockResolveCurrentVersion,
+        {
+          // Apply the groups filter to only include projectL in versioning.
+          groups: ['projectK'],
+        }
+      );
+
+      const processor = new ReleaseGroupProcessor(
+        tree,
+        projectGraph,
+        nxReleaseConfig,
+        releaseGroups,
+        releaseGroupToFilteredProjects,
+        {
+          dryRun: false,
+          verbose: false,
+          firstRelease: false,
+          preid: undefined,
+          filters,
+        }
+      );
+      await processor.init();
+
+      mockDeriveSpecifierFromConventionalCommits.mockImplementation(
+        () => 'minor'
+      );
+      await processor.processGroups();
+
+      // projectJ should not be bumped because updateDependents is set to "never"
+      expect(readJson(tree, 'projectJ/package.json')).toMatchInlineSnapshot(`
+        {
+          "dependencies": {
+            "projectK": "2.1.0",
+          },
+          "name": "projectJ",
+          "version": "1.0.1",
+        }
+      `);
+      // projectK should not be bumped because updateDependents is set to "never"
+      expect(readJson(tree, 'projectK/package.json')).toMatchInlineSnapshot(`
+        {
+          "name": "projectK",
+          "version": "2.1.0",
+        }
+      `);
+    });
+
     it('should filter out projects with no dependency relationships within a single independent release group based on the provided user filter', async () => {
       const {
         nxReleaseConfig,

packages/nx/src/command-line/release/version/release-group-processor.ts

@@ -323,6 +323,18 @@ export class ReleaseGroupProcessor {
       });
     }
 
+    for (const [groupName, group] of Object.entries(
+      this.nxReleaseConfig.groups
+    )) {
+      if (!this.groupGraph.has(groupName)) {
+        this.groupGraph.set(groupName, {
+          group: { ...group, name: groupName, resolvedVersionPlans: false },
+          dependencies: new Set(),
+          dependents: new Set(),
+        });
+      }
+    }
+
     // Process each project within each release group
     for (const [, releaseGroupNode] of this.groupGraph) {
       for (const projectName of releaseGroupNode.group.projects) {
@@ -423,6 +435,26 @@ export class ReleaseGroupProcessor {
         this.projectToUpdateDependentsSetting.set(project, updateDependents);
       }
     }
+
+    for (const [groupName, group] of Object.entries(
+      this.nxReleaseConfig.groups
+    )) {
+      for (const project of group.projects) {
+        if (!this.projectToReleaseGroup.has(project)) {
+          this.projectToReleaseGroup.set(project, {
+            ...group,
+            name: groupName,
+            resolvedVersionPlans: false,
+          });
+
+          // Cache updateDependents setting relevant for each project
+          const updateDependents =
+            ((group.version as NxReleaseVersionConfiguration)
+              ?.updateDependents as 'auto' | 'never') || 'auto';
+          this.projectToUpdateDependentsSetting.set(project, updateDependents);
+        }
+      }
+    }
   }
 
   /**
@@ -1064,7 +1096,8 @@ export class ReleaseGroupProcessor {
     for (const project of sortedProjects) {
       if (
         projectsToUpdate.has(project) &&
-        releaseGroupFilteredProjects.has(project)
+        (releaseGroupFilteredProjects?.has(project) ||
+          this.isDependentUpdate(project))
       ) {
         await this.updateDependenciesForProject(project);
       }
@@ -1722,4 +1755,12 @@ Valid values are: ${validReleaseVersionPrefixes
   private getProjectDependencies(project: string): Set<string> {
     return this.projectToDependencies.get(project) || new Set();
   }
+
+  private isDependentUpdate(project: string) {
+    return (
+      Array.from(this.projectToDependents.values()).some((dependents) =>
+        dependents.has(project)
+      ) && this.hasAutoUpdateDependents(project)
+    );
+  }
 }