fix(misc): remove unnecessary bust property from plugin hashes (#32807)

Remove the manually maintained and unnecessary `bust` property from
plugin hashes.

Author: leosvelperez

packages/eslint/src/plugins/plugin.ts

@@ -5,6 +5,7 @@ import {
   createNodesFromFiles,
   CreateNodesResult,
   CreateNodesV2,
+  detectPackageManager,
   getPackageManagerCommand,
   logger,
   readJsonFile,
@@ -15,17 +16,18 @@ import {
   calculateHashesForCreateNodes,
   calculateHashForCreateNodes,
 } from '@nx/devkit/src/utils/calculate-hash-for-create-nodes';
+import { getLockFileName } from '@nx/js';
+import type { ESLint as ESLintType } from 'eslint';
 import { existsSync } from 'node:fs';
 import { basename, dirname, join, normalize, sep } from 'node:path/posix';
 import { hashObject } from 'nx/src/hasher/file-hasher';
 import { workspaceDataDirectory } from 'nx/src/utils/cache-directory';
 import { combineGlobPatterns } from 'nx/src/utils/globs';
 import { globWithWorkspaceContext } from 'nx/src/utils/workspace-context';
 import { gte } from 'semver';
-import type { ESLint as ESLintType } from 'eslint';
 import {
-  baseEsLintConfigFile,
   BASE_ESLINT_CONFIG_FILENAMES,
+  baseEsLintConfigFile,
   ESLINT_CONFIG_FILENAMES,
   isFlatConfig,
 } from '../utils/config-file';
@@ -135,14 +137,13 @@ const internalCreateNodes = async (
       );
       const hash = await calculateHashForCreateNodes(
         childProjectRoot,
-        {
-          ...options,
-          // change this to bust the cache when making changes that would yield
-          // different results for the same hash
-          bust: 1,
-        },
+        options,
         context,
-        [...parentConfigs, join(childProjectRoot, '.eslintignore')]
+        [
+          ...parentConfigs,
+          join(childProjectRoot, '.eslintignore'),
+          getLockFileName(detectPackageManager(context.workspaceRoot)),
+        ]
       );
 
       if (projectsCache[hash]) {
@@ -280,20 +281,18 @@ export const createNodesV2: CreateNodesV2<EslintPluginOptions> = [
       options,
       context
     );
+    const lockFilePattern = getLockFileName(
+      detectPackageManager(context.workspaceRoot)
+    );
     const hashes = await calculateHashesForCreateNodes(
       projectRoots,
-      {
-        ...options,
-        // change this to bust the cache when making changes that would yield
-        // different results for the same hash
-        bust: 1,
-      },
+      options,
       context,
       projectRoots.map((root) => {
         const parentConfigs = eslintConfigFiles.filter((eslintConfig) =>
           isSubDir(root, dirname(eslintConfig))
         );
-        return [...parentConfigs, join(root, '.eslintignore')];
+        return [...parentConfigs, join(root, '.eslintignore'), lockFilePattern];
       })
     );
     const hashByRoot = new Map<string, string>(

packages/js/src/plugins/typescript/plugin.ts

@@ -363,9 +363,6 @@ async function getConfigFileHash(
     lockFileHash,
     optionsHash,
     ...(packageJson ? [hashObject(packageJson)] : []),
-    // change this to bust the cache when making changes that would yield
-    // different results for the same hash
-    hashObject({ bust: 3 }),
   ]);
 }
 

packages/nx/src/plugins/package-json/create-nodes.ts

@@ -16,6 +16,7 @@ import {
   readTargetsFromPackageJson,
 } from '../../utils/package-json';
 import { joinPathFragments } from '../../utils/path';
+import { nxVersion } from '../../utils/versions';
 import {
   createNodesFromFiles,
   CreateNodesV2,
@@ -144,9 +145,7 @@ export function createNodeFromPackageJson(
     ...json,
     root: projectRoot,
     isInPackageManagerWorkspaces,
-    // change this to bust the cache when making changes that result in different
-    // results for the same hash
-    bust: 1,
+    nxVersion,
   });
 
   const cached = cache[hash];