Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(misc): handle external nodes correctly in module federation additional shared config #11018

Merged

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Jul 5, 2022

Current Behavior

Providing an npm package that is a dependency of a module federation application as an additional shared dependency fails with an error stating that the package doesn't exist in the project graph:

module.exports = {
  name: 'host',
  remotes: ['remote1', 'remote2'],
  additionalShared: ['@some/awesome-package'],
};

Expected Behavior

Providing an npm package that is a dependency of a module federation application as an additional shared dependency should work correctly and the npm package should be shared.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from Coly010 July 5, 2022 13:00
@leosvelperez leosvelperez self-assigned this Jul 5, 2022
@vercel
Copy link

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jul 5, 2022 at 1:00PM (UTC)

Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@leosvelperez leosvelperez merged commit 23d94a8 into nrwl:master Jul 5, 2022
@leosvelperez leosvelperez deleted the misc/fix-mf-additional-shared branch July 5, 2022 13:21
@kenatwex
Copy link

kenatwex commented Nov 8, 2022

well Im getting somewhere here... close...
but cannot get past
@angular/common/http

MFE shared refuses to accept it

is this a bug?

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants