fix(misc): handle external nodes correctly in module federation addit…

…ional shared config
nrwl · Jul 5, 2022 · d8918bc · d8918bc
1 parent 6a63138
commit d8918bc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/angular/src/utils/mf/with-module-federation.ts b/packages/angular/src/utils/mf/with-module-federation.ts
@@ -180,7 +180,7 @@ function addStringDependencyToSharedConfig(
 ): void {
   if (projectGraph.nodes[dependency]) {
     sharedConfig[dependency] = { requiredVersion: false };
-  } else if (projectGraph.externalNodes?.[dependency]) {
+  } else if (projectGraph.externalNodes?.[`npm:${dependency}`]) {
     const pkgJson = readRootPackageJson();
     const config = getNpmPackageSharedConfig(
       dependency,

diff --git a/packages/react/src/module-federation/with-module-federation.ts b/packages/react/src/module-federation/with-module-federation.ts
@@ -170,7 +170,7 @@ function addStringDependencyToSharedConfig(
 ): void {
   if (projectGraph.nodes[dependency]) {
     sharedConfig[dependency] = { requiredVersion: false };
-  } else if (projectGraph.externalNodes?.[dependency]) {
+  } else if (projectGraph.externalNodes?.[`npm:${dependency}`]) {
     const pkgJson = readRootPackageJson();
     const config = getNpmPackageSharedConfig(
       dependency,