fix: Add support for receiving roStoryX, roItemY messages (SOFIE-2858) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These all have functionally equivalent roElementAction messages, so the consumer API is unchanged. Addded messages: roStoryAppend, roStoryInsert, roStoryReplace, roStoryMove, roStorySwap, roStoryDelete, roStoryMoveMultiple, roItemInsert, roItemReplace, roItemDelete, roItemMoveMultiple.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 77.58% 77.84% +0.26%
==========================================
Files 63 63
Lines 3395 3422 +27
Branches 768 778 +10
==========================================
+ Hits 2634 2664 +30
+ Misses 679 676 -3
Partials 82 82 ☔ View full report in Codecov by Sentry. |
This was
linked to
issues
Dec 21, 2023
nytamin
changed the title
|
These changes have now been published in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is posted on behald of the NRK.
Type of Contribution
This can be considered a bug fix. It adds support for a few missing MOS messages, that should have been there from the start.
This doesn't affect the consumer-side API of the library.
Current Behavior
As reported in #86 and #57, if, for example, a
<roStoryReplace>message is received, the library will emit the error"Unsupported function".While these types of messages are considered deprecated_ they should still be supported.
Quote from the mos protocol documentation:
New Behavior
Library now supports the following messages:
All these messages have equivalent functionality in the
roElementActionwhich is already supported, so a call to one of these will result in calls to the already existing callbacks (so no code changes are required in the consumer code).Testing Instructions
This can be tested using
Other Information
Status