Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for deprecated Profile 2 MOS calls #57

Closed
ebuzzz opened this issue Jun 15, 2021 · 2 comments · Fixed by #87
Closed

Support for deprecated Profile 2 MOS calls #57

ebuzzz opened this issue Jun 15, 2021 · 2 comments · Fixed by #87
Labels
help wanted Noone is actively working on this, contributions are welcome

Comments

@ebuzzz
Copy link

ebuzzz commented Jun 15, 2021

  • I'm submitting a ...
    [ ] bug report
    [ ] feature request
    [x] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary

We are currently using the library to connect to a NCS which supports MOS 2.8 (the initial version), but also makes use of the deprecated profile2 calls like roStoryDelete, roStoryMove, roStoryMoveMultiple, etc.

I need to implement these methods, but are you interested in a pull request, or has a decision been made to not implement these calls in this library
@nytamin
Copy link
Contributor

nytamin commented Jul 2, 2021

Hi! Sorry for the slow response.
We'd be happy to accept a PR adding those deprecated messages, we didn't include them in the first place simply because we hadn't had a use for them ourselves.

@nytamin nytamin added the help wanted Noone is actively working on this, contributions are welcome label Aug 9, 2023
@PascalViauRC PascalViauRC mentioned this issue Dec 20, 2023
Closed
@nytamin nytamin mentioned this issue Dec 21, 2023
Merged
4 tasks
@nytamin nytamin linked a pull request Dec 21, 2023 that will close this issue
fix: Add support for receiving roStoryX, roItemY messages (SOFIE-2858) #87
Merged
4 tasks
@nytamin
Copy link
Contributor

nytamin commented Dec 27, 2023

This has now been fixed, in version 3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Noone is actively working on this, contributions are welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add support for receiving roStoryX, roItemY messages (SOFIE-2858) nrkno/sofie-mos-connection
2 participants
@ebuzzz @nytamin