fix(ls): fix descriptions in --long human output#8903
Open
jbrobst wants to merge 2 commits intonpm:latestfrom
Open
fix(ls): fix descriptions in --long human output#8903jbrobst wants to merge 2 commits intonpm:latestfrom
jbrobst wants to merge 2 commits intonpm:latestfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having arborist's
loadActualuse a hidden lockfile caused a lot of the information in actualpackage.jsonfiles to not be available in the tree, some of which is relied upon by cli commands likels --longto output descriptions. This was fixed fornpm queryin #5263 by adding an option to avoid the hidden lockfile,forceActual. So, use this option forls --longas well.Additionally,
ls --long's unconditional access ofnode.package.descriptionerrors whennode.packageis undefined (#5961). This happens whennodeis not an arborist node but rather an object created bymapEdgesToNodesrepresenting a missing linked node. Address this by making description output conditional onnode[_missing], as was similarly done forls --json --longin 2aecec5.