You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
arborist's loadActual() method checks for a hidden lockfile first, if one exists we load the tree virtually which causes us to lose quite a lot of data. this pull request introduces a new flag for arborist to forcibly skip this virtual loading and instead do an actual tree load, which brings back the properties we were missing
Is there an alternative, which is populating the hidden lockfile's virtual tree with all that on-disk data?
we could but then we have to carefully consider what data is currently available in the lockfile vs what users may want to query against, and we're likely to increase the size of the hidden lockfile by quite a bit.
to be honest, i'm pursuing some digging because i think the difference in available data when loading a tree virtually vs actually is very probably the source of some bugs. my first priority was fixing npm query so it will behave more consistently how users expect. it's entirely probable i'll be making some more foundational changes in arborist later, but that can wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arborist's
loadActual()method checks for a hidden lockfile first, if one exists we load the tree virtually which causes us to lose quite a lot of data. this pull request introduces a new flag for arborist to forcibly skip this virtual loading and instead do an actual tree load, which brings back the properties we were missing