Merged
Conversation
wraithgar
force-pushed
the
gar/test-mocks
branch
2 times, most recently
from
aba3f33 to
31fa0e1
Compare
Contributor
|
no statistically significant performance changes detected timing results
|
wraithgar
force-pushed
the
gar/test-mocks
branch
6 times, most recently
from
fc03cfb to
b573bc1
Compare
Member
Author
|
Ok I'm done with this round of test cleanups. |
Contributor
|
Looks like there's the possibility of a flaky test with a snapshot here: https://github.com/npm/cli/runs/5796752839?check_suite_focus=true#step:5:42 |
nlf
approved these changes
Apr 4, 2022
Contributor
nlf
left a comment
nlf
left a comment
There was a problem hiding this comment.
lots of clear improvements here 👍
* Removed dedupe --save documentation and attempted implementation. * Remove some unneeded otplease mocks from test `npm dedupe --save` didn't work in a easy to understand way. It would only update a top level dependency that was duplicated in the tree. Found this out rewriting the dedupe tests to be real. This is not very intuitive and it's best if folks use update or install for saving to package.json.
wraithgar
force-pushed
the
gar/test-mocks
branch
from
b573bc1 to
55db9dd
Compare
Member
Author
|
flaky test fixed, thanks @lukekarrys |
lukekarrys
approved these changes
Apr 4, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing more mocks from tests.