Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont export include-workspace-root to env #4675

Closed
wants to merge 1 commit into from

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Apr 4, 2022

this fixes npm run test-all for ourselves, and likely may help with scripts that somehow end up recursive (because at least only the root will be run once)

@nlf nlf requested a review from a team as a code owner April 4, 2022 18:11
@nlf
Copy link
Contributor Author

nlf commented Apr 4, 2022

closing in favor of #4645

@nlf nlf closed this Apr 4, 2022
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 53.741 ±1.90 28.517 ±1.47 27.884 ±17.01 18.281 ±0.53 2.825 ±0.07 2.922 ±0.01 2.261 ±0.04 10.199 ±0.11 2.217 ±0.02 3.086 ±0.07
#4675 49.623 ±2.75 28.095 ±0.06 16.024 ±0.63 18.859 ±0.95 2.793 ±0.05 2.806 ±0.16 2.240 ±0.06 10.767 ±0.18 2.127 ±0.06 3.242 ±0.18
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.441 ±0.75 21.976 ±0.08 12.053 ±0.06 12.757 ±0.20 2.536 ±0.04 2.393 ±0.01 2.168 ±0.11 8.085 ±0.15 2.116 ±0.04 2.645 ±0.03
#4675 36.320 ±3.10 21.998 ±0.75 12.232 ±0.29 12.966 ±0.29 2.446 ±0.01 2.414 ±0.04 2.194 ±0.08 8.050 ±0.09 1.995 ±0.01 2.826 ±0.12

@nlf nlf deleted the nlf/dont-export-include-workspace-root branch April 4, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants