Invalid dates - Fix 2 #805
Conversation
|
@nozzlegear are you able to merge and release? |
|
by the way, it would be great if I was somehow able to make releases myself. Even if they are marked as pre-release in nuget, this would help me greatly with emergency fixes... something to think about maybe... |
|
Woops sorry about that, I don't remember seeing an email or notification for this pull request. I'll publish as soon as the tests pass. |
|
you're the man! |
I don't have a problem with this! I think it would require me giving you write access to the repo. I've got the build pipeline set up to push new prerelease builds to nuget whenever tests pass, so all you'd need to do is merge your own pull requests I think. |
that would be great 😀 |
|
Alright, I sent the collaborator invite! Feel free to send and merge pull requests as you see fit. Once they're merged the tests will run and if they pass the pipeline should push the changes to nuget as a new prerelease version. |
|
And just to be clear, you can merge other people's pull requests as well if I don't get to them first! You've put in a lot of work on this package over the years so I have no reason not to trust your judgement. But of course, don't take on any extra work that you don't want to as well! |
|
thank you, that is much appreciated 😀 |
|
No problem! And this fix is now published in 5.18.8 on nuget. Thanks for the PR! |
This ensure that if an invalid date is present in the API, it is converted to NULL.
It expands on the previous fix, which was only handling invalid dates when deserializing from a webhook json.